electric-cherry/tests/unit/fleet-settings.test.ts

import { afterEach, beforeEach, describe, expect, it, vi } from 'vitest';
import { newFixture, type Fixture } from '../helpers/fixture.js';

let fixture: Fixture;
const defaults = { deployKeepDays: 7, restartConcurrency: 1, createConcurrency: 1 };
beforeEach(async () => {
    vi.resetModules();
    fixture = await newFixture([]);
    for (const key of ['DEPLOY_KEEP_DAYS', 'DEPLOYMENT_RESTART_CONCURRENCY', 'DEPLOYMENT_CREATE_CONCURRENCY']) vi.stubEnv(key, undefined);
});
afterEach(async () => { await fixture.cleanup(); vi.unstubAllEnvs(); });

describe('fleet settings API and persistence', () => {
    it('returns defaults and saves all settings across a module reload and database reopen', async () => {
        const { GET, PUT } = await import('../../src/routes/api/settings/+server.js');
        expect(await GET().json()).toEqual(defaults);
        const saved = { deployKeepDays: 30, restartConcurrency: 3, createConcurrency: 2 };
        const response = await PUT({ request: new Request('http://localhost/api/settings', { method: 'PUT', body: JSON.stringify(saved) }) });
        expect(response.status).toBe(200);
        expect(await response.json()).toEqual(saved);
        const { closeDb } = await import('../../src/lib/server/db/index.js');
        closeDb(); vi.resetModules();
        // Once saved, even invalid legacy environment values are irrelevant.
        vi.stubEnv('DEPLOY_KEEP_DAYS', '-1');
        vi.stubEnv('DEPLOYMENT_RESTART_CONCURRENCY', 'bad');
        vi.stubEnv('DEPLOYMENT_CREATE_CONCURRENCY', '9');
        const reopened = await import('../../src/routes/api/settings/+server.js');
        expect(await reopened.GET().json()).toEqual(saved);
    });

    it('imports legacy values into an existing database once and preserves unrelated settings', async () => {
        const { db, closeDb } = await import('../../src/lib/server/db/index.js');
        db().prepare("DELETE FROM settings WHERE key = 'fleet_settings'").run();
        db().prepare("INSERT INTO settings (key, value) VALUES ('unrelated', 'true')").run();
        closeDb();
        vi.stubEnv('DEPLOY_KEEP_DAYS', '14');
        vi.stubEnv('DEPLOYMENT_RESTART_CONCURRENCY', '4');
        vi.stubEnv('DEPLOYMENT_CREATE_CONCURRENCY', '2');
        const { fleetSettings } = await import('../../src/lib/server/settings.js');
        expect(fleetSettings()).toEqual({ deployKeepDays: 14, restartConcurrency: 4, createConcurrency: 2 });
        closeDb();
        vi.stubEnv('DEPLOY_KEEP_DAYS', '7');
        expect(fleetSettings().deployKeepDays).toBe(14);
        expect(db().prepare("SELECT value FROM settings WHERE key = 'unrelated'").get()).toEqual({ value: 'true' });
    });

    it.each([
        'null', '[]', '{}', '{',
        ...['deployKeepDays', 'restartConcurrency', 'createConcurrency'].flatMap(key =>
            [0, -1, 1.5, '2', true, null, 9007199254740992].map(value => JSON.stringify({ ...defaults, [key]: value }))),
        JSON.stringify({ ...defaults, deployKeepDays: 36501 }),
        JSON.stringify({ ...defaults, unknown: 1 })
    ])('rejects invalid input without partially saving: %s', async body => {
        const { GET, PUT } = await import('../../src/routes/api/settings/+server.js');
        const response = await PUT({ request: new Request('http://localhost/api/settings', { method: 'PUT', body }) });
        expect(response.status).toBe(400);
        expect(await response.json()).toHaveProperty('error');
        expect(await GET().json()).toEqual(defaults);
    });
});

it('applies saved retention to cleanup while protecting unfinished campaigns and provisioning history', async () => {
    const { db } = await import('../../src/lib/server/db/index.js');
    const { fleetSettings, saveFleetSettings } = await import('../../src/lib/server/settings.js');
    const { sweep } = await import('../../src/lib/server/pipeline/sweep.js');
    const old = new Date(Date.now() - 10 * 86400000).toISOString();
    for (const id of ['completed', 'pending', 'failed', 'held']) {
        db().prepare("INSERT INTO deployments (id, action, started_at) VALUES (?, 'test', ?)").run(id, old);
        db().prepare('INSERT INTO deployment_servers (deployment_id, server, restart_state, files_changed) VALUES (?, ?, ?, 0)')
            .run(id, 'server-' + id, id === 'completed' ? 'done' : id);
    }
    db().prepare("INSERT INTO server_deployments (id, server, action, state, stage, started_at, triggered_by) VALUES ('history', 'removed', 'destroy', 'done', 'Complete', ?, 'ui')").run(old);
    saveFleetSettings({ ...fleetSettings(), deployKeepDays: 30 });
    await sweep();
    expect(db().prepare('SELECT id FROM deployments').all()).toHaveLength(4);
    saveFleetSettings({ ...fleetSettings(), deployKeepDays: 7 });
    await sweep();
    expect(db().prepare('SELECT id FROM deployments ORDER BY id').all()).toEqual([{ id: 'failed' }, { id: 'held' }, { id: 'pending' }]);
    expect(db().prepare("SELECT server FROM deployment_servers WHERE deployment_id = 'completed'").all()).toEqual([]);
    expect(db().prepare('SELECT id FROM server_deployments').all()).toEqual([{ id: 'history' }]);
});