"unparseable reply (34 bytes)" told us Plutonium answered but hid the actual bytes, forcing another guess-and-check round. rconStatusResult now emits a formatRawReply() hex + ASCII dump of the raw UDP payload on every bad-reply, persisted in a new last_reply_snippet column so it survives page loads. Wrong-password detection widens beyond the "bad rcon" phrasing to "(bad|invalid|wrong)…(rcon|password|pass)"; print-body replies that don't match get their first non-header line surfaced verbatim so at least *some* server-supplied text reaches the UI. Probe RCON button (POST /api/servers/[name]/probe-rcon) fires the same code path as the periodic sweep on demand, cuts the RCON iteration loop from 30s per attempt to sub-second, and refreshes the header/roster/ health when it succeeds. Snippet <details> auto-opens on bad-reply so the bytes are one glance away. migrateServers() picks up the new column automatically via the introspection path added last commit. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
140 lines
4.9 KiB
TypeScript
140 lines
4.9 KiB
TypeScript
import { describe, expect, it } from 'vitest';
|
|
import {
|
|
parseInfoLine,
|
|
parsePlayerCount,
|
|
parsePlayerRoster,
|
|
formatRawReply
|
|
} from '../../src/lib/server/integrations/rcon.js';
|
|
|
|
describe('parsePlayerCount', () => {
|
|
it('counts rows after --- --- separator (status dialect)', () => {
|
|
const body = [
|
|
'print',
|
|
'map: mp_kino',
|
|
'num score ping guid name',
|
|
'--- ----- ---- -------- ----',
|
|
' 0 12 45 abc123def456 joe',
|
|
' 1 0 72 xyz789abc123 jill',
|
|
' 2 999 30 111222333444 kade'
|
|
].join('\n');
|
|
expect(parsePlayerCount(body)).toBe(3);
|
|
});
|
|
|
|
it('returns 0 when the scoreboard has no rows', () => {
|
|
const body = [
|
|
'print',
|
|
'map: mp_ascension',
|
|
'num score ping guid name',
|
|
'--- ----- ---- -------- ----',
|
|
''
|
|
].join('\n');
|
|
expect(parsePlayerCount(body)).toBe(0);
|
|
});
|
|
|
|
it('counts non-blank lines after the info line (statusResponse dialect)', () => {
|
|
const body = [
|
|
'statusResponse',
|
|
'\\mapname\\mp_kino\\g_gametype\\zom\\sv_maxclients\\4',
|
|
'10 45 "joe"',
|
|
'0 72 "jill"'
|
|
].join('\n');
|
|
expect(parsePlayerCount(body)).toBe(2);
|
|
});
|
|
|
|
it('returns null on malformed payloads with no separator or info line', () => {
|
|
expect(parsePlayerCount('nonsense body\nno structure here')).toBeNull();
|
|
});
|
|
});
|
|
|
|
describe('parseInfoLine', () => {
|
|
it('splits \\key\\value pairs from an info string', () => {
|
|
const body = [
|
|
'statusResponse',
|
|
'\\mapname\\mp_kino\\g_gametype\\zom\\sv_maxclients\\4'
|
|
].join('\n');
|
|
const info = parseInfoLine(body);
|
|
expect(info.mapname).toBe('mp_kino');
|
|
expect(info.g_gametype).toBe('zom');
|
|
expect(info.sv_maxclients).toBe('4');
|
|
});
|
|
|
|
it('returns empty object when no info line is present', () => {
|
|
expect(parseInfoLine('nothing here')).toEqual({});
|
|
});
|
|
});
|
|
|
|
describe('parsePlayerRoster', () => {
|
|
it('extracts num/score/ping/guid/name from print dialect', () => {
|
|
const body = [
|
|
'print',
|
|
'map: mp_kino',
|
|
'num score ping guid name',
|
|
'--- ----- ---- -------- ----',
|
|
' 0 12 45 aaaaaaaabbbbbbbbccccccccdddddddd joe',
|
|
' 1 0 72 11112222333344445555666677778888 jill h.',
|
|
' 2 999 128 abcdef0123456789abcdef0123456789 Toaster'
|
|
].join('\n');
|
|
const roster = parsePlayerRoster(body);
|
|
expect(roster).toHaveLength(3);
|
|
expect(roster[0]).toEqual({
|
|
num: 0,
|
|
score: 12,
|
|
ping: 45,
|
|
guid: 'aaaaaaaabbbbbbbbccccccccdddddddd',
|
|
name: 'joe'
|
|
});
|
|
// Names with spaces stay intact
|
|
expect(roster[1].name).toBe('jill h.');
|
|
expect(roster[2].ping).toBe(128);
|
|
});
|
|
|
|
it('extracts score/ping/quoted-name from statusResponse dialect', () => {
|
|
const body = [
|
|
'statusResponse',
|
|
'\\mapname\\mp_kino\\g_gametype\\zclassic',
|
|
'10 45 "joe"',
|
|
'0 72 "jill h."'
|
|
].join('\n');
|
|
const roster = parsePlayerRoster(body);
|
|
expect(roster).toHaveLength(2);
|
|
expect(roster[0]).toEqual({
|
|
num: null,
|
|
score: 10,
|
|
ping: 45,
|
|
guid: null,
|
|
name: 'joe'
|
|
});
|
|
expect(roster[1].name).toBe('jill h.');
|
|
});
|
|
|
|
it('returns empty array when no rows are present', () => {
|
|
const empty = [
|
|
'print',
|
|
'map: mp_ascension',
|
|
'num score ping guid name',
|
|
'--- ----- ---- -------- ----'
|
|
].join('\n');
|
|
expect(parsePlayerRoster(empty)).toEqual([]);
|
|
expect(parsePlayerRoster('nonsense')).toEqual([]);
|
|
});
|
|
});
|
|
|
|
describe('formatRawReply', () => {
|
|
it('renders a small buffer as hex + printable ASCII with an offset', () => {
|
|
const buf = Buffer.from([0xff, 0xff, 0xff, 0xff, 0x70, 0x72, 0x69, 0x6e, 0x74, 0x0a]);
|
|
const out = formatRawReply(buf);
|
|
expect(out).toContain('0000');
|
|
expect(out).toContain('ff ff ff ff 70 72 69 6e 74 0a');
|
|
// Non-printable prefix bytes render as `.`; the printable tail spells "print".
|
|
expect(out).toContain('....print.');
|
|
});
|
|
|
|
it('splits into 16-byte rows and truncates past the limit', () => {
|
|
const buf = Buffer.alloc(600, 0x41); // "A" repeated
|
|
const out = formatRawReply(buf);
|
|
const lines = out.split('\n');
|
|
expect(lines.length).toBeGreaterThan(1);
|
|
expect(lines[lines.length - 1]).toMatch(/more bytes/);
|
|
});
|
|
});
|