Provisioning job page is padded with empty rows and explanatory copy #88

Closed
opened 2026-10-08 19:11:23 -04:00 by goddard · 1 comment
Collaborator

Many rows on the job page have no value, and many paragraphs explain the page rather than the operation.

  • Empty rows: "Submission attempted: Not recorded" (+page.svelte:176) and "Last evaluated: Not recorded" (+page.svelte:141) on operations that never record them.
  • Explanatory paragraphs: related work (+page.svelte:181), controller activity (+page.svelte:166), capacity request order (+page.svelte:188), and a help paragraph under each recovery action (+page.svelte:123-129).
  • Outcome descriptions are long and hedged (provisioning-presentation.ts:83-128). A success reads "The operation completed its readiness checks. These recorded results describe that attempt; current health is available on the server page."

Screenshots

From the synthetic UI preview. Progress records and a launch recipe were added to the disposable fixture database using the labels the worker records. "After" images are mockups made in an uncommitted copy.

Before:
Before

After (mockup):
After (mockup)

Fix

  • Hide rows that have no value for this kind of operation
  • Move explanatory copy to tooltips, confirmation dialogs or the provisioning guide
  • Give successful operations no description, or one short sentence
Many rows on the job page have no value, and many paragraphs explain the page rather than the operation. - Empty rows: "Submission attempted: Not recorded" (`+page.svelte:176`) and "Last evaluated: Not recorded" (`+page.svelte:141`) on operations that never record them. - Explanatory paragraphs: related work (`+page.svelte:181`), controller activity (`+page.svelte:166`), capacity request order (`+page.svelte:188`), and a help paragraph under each recovery action (`+page.svelte:123-129`). - Outcome descriptions are long and hedged (`provisioning-presentation.ts:83-128`). A success reads "The operation completed its readiness checks. These recorded results describe that attempt; current health is available on the server page." **Screenshots** _From the synthetic UI preview. Progress records and a launch recipe were added to the disposable fixture database using the labels the worker records. "After" images are mockups made in an uncommitted copy._ Before: ![Before](https://gitea.thewrightserver.net/attachments/f0adb5ce-5142-4501-be94-e4dbd5ca13ee) After (mockup): ![After (mockup)](https://gitea.thewrightserver.net/attachments/1097fa39-30c2-4573-b692-26a7bd56e0a1) **Fix** - [x] Hide rows that have no value for this kind of operation - [x] Move explanatory copy to tooltips, confirmation dialogs or the provisioning guide - [x] Give successful operations no description, or one short sentence
goddard added the
priority
low
type/ux
labels 2026-10-08 19:11:23 -04:00
josh was assigned by goddard 2026-10-08 19:11:23 -04:00
Author
Collaborator

Reviewed 967b2a1c8a. All three fix items are done, so I'm closing this.

Checklist

  • Rows without a value hidden. "Finished" and "Submission attempted" only appear when recorded (+page.svelte:224-225). The timing row only appears with a phase start or an evaluation time (+page.svelte:178). The Launch files card is hidden for Start, Restart and Stop unless an older operation has a recipe (+page.svelte:212).
  • Explanatory copy moved. The related-work and controller-activity paragraphs are gone from the page and covered in the provisioning guide. The request-order caveat is now a tooltip (+page.svelte:208). The help under each recovery action moved into confirmation dialogs: Cancel and Cancel creation now confirm first (+page.svelte:89,100), and Retry with rebuild and Admin override already did.
  • No description for success. Completed operations now have none (provisioning-presentation.ts:155), and the page skips the empty paragraph (+page.svelte:153).

Review notes

  • Good extra: Cancel operation and Cancel creation used to act on the first click. Cancel creation deletes the container and instance files, so the new confirmations are a real safety improvement.
  • In the synthetic preview, a completed rebuild's outcome is just "Server rebuilt · ✓ All 5 checks passed", and a completed restart has no timing row, no Launch files card and no empty Submission row.
  • The 3 related test files pass locally (93 tests), and npm run check reports 0 errors.
  • Minor and non-blocking: the test changes only update the outcome description assertions. Nothing covers the hidden rows, the Launch files condition or the two new confirmation dialogs.
Reviewed 967b2a1c8a77ae055bb4a609669c9637ba2fdaa9. All three fix items are done, so I'm closing this. **Checklist** - [x] **Rows without a value hidden.** "Finished" and "Submission attempted" only appear when recorded (`+page.svelte:224-225`). The timing row only appears with a phase start or an evaluation time (`+page.svelte:178`). The Launch files card is hidden for Start, Restart and Stop unless an older operation has a recipe (`+page.svelte:212`). - [x] **Explanatory copy moved.** The related-work and controller-activity paragraphs are gone from the page and covered in the provisioning guide. The request-order caveat is now a tooltip (`+page.svelte:208`). The help under each recovery action moved into confirmation dialogs: Cancel and Cancel creation now confirm first (`+page.svelte:89,100`), and Retry with rebuild and Admin override already did. - [x] **No description for success.** Completed operations now have none (`provisioning-presentation.ts:155`), and the page skips the empty paragraph (`+page.svelte:153`). **Review notes** - Good extra: Cancel operation and Cancel creation used to act on the first click. Cancel creation deletes the container and instance files, so the new confirmations are a real safety improvement. - In the synthetic preview, a completed rebuild's outcome is just "Server rebuilt · ✓ All 5 checks passed", and a completed restart has no timing row, no Launch files card and no empty Submission row. - The 3 related test files pass locally (93 tests), and `npm run check` reports 0 errors. - Minor and non-blocking: the test changes only update the outcome description assertions. Nothing covers the hidden rows, the Launch files condition or the two new confirmation dialogs.
Sign in to join this conversation.