josh/tws-zombies-scripts
0
0
Fork 0
Code Issues 7 Pull Requests Actions Packages Projects Releases Wiki Activity

Telemetry sends current score for game_end #1

New Issue
Closed
opened 2026-10-02 13:20:11 -04:00 by josh · 1 comment
josh commented 2026-10-02 13:20:11 -04:00
Owner
Copy Link
Copy Source

image.png

Is it possible to send final score?

![image.png](/attachments/d5cb6cfb-1d72-40dd-aee3-bbd8cd7da8f6) Is it possible to send final score?
image.png
101 KiB
goddard commented 2026-10-13 14:54:01 -04:00
Collaborator
Copy Link
Copy Source

Reviewed b508b6739b against current main 463b4bcc51. The requested cumulative match score is implemented on both engines.

Checklist

  • Final earned score. Both telemetry serializers send score_total alongside spendable score on stat reports, including game_end.
  • End-of-game capture. The first end signal captures the two values before stock intermission overwrites the spendable balance. Retries replay the original serialized values.

Review notes

  • node tools/check_telemetry.mjs: all 23 checks passed for T5/T6, including differing spendable/cumulative scores, scoreboard overwrite timing, and replay preservation.
  • This is source/portable fixture validation, not a new live match test. EC must consume score_total for display; these scripts preserve the original score field for compatibility.
  • Leaving issue state unchanged because Josh created it; Goddard's standing issue-management scope only permits closing Goddard-created issues.
Reviewed b508b6739b185d5048e8a8f96ccb16e429f1d37a against current main 463b4bcc51871ef4f24f6360c35ff11c443be138. The requested cumulative match score is implemented on both engines. **Checklist** - [x] **Final earned score.** Both telemetry serializers send `score_total` alongside spendable `score` on stat reports, including `game_end`. - [x] **End-of-game capture.** The first end signal captures the two values before stock intermission overwrites the spendable balance. Retries replay the original serialized values. **Review notes** - `node tools/check_telemetry.mjs`: all 23 checks passed for T5/T6, including differing spendable/cumulative scores, scoreboard overwrite timing, and replay preservation. - This is source/portable fixture validation, not a new live match test. EC must consume `score_total` for display; these scripts preserve the original `score` field for compatibility. - Leaving issue state unchanged because Josh created it; Goddard's standing issue-management scope only permits closing Goddard-created issues.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
game/t5
Affects the T5 scripts or plugin
 game/t6
Affects the T6 scripts or plugin
 needs/ec
Needs an Electric Cherry change to ship or finish
 type/bug
Incorrect or broken behaviour
 type/exploit
Lets players gain an unfair advantage or inflate map records
 type/feature
New capability for players
 type/hardening
Defense-in-depth and robustness improvements
 type/maintainability
Code health, tooling and cleanup
 type/security
Security vulnerability or data exposure
 type/ux
Usability, wording and interaction improvements for players
priority
high
Fix first: server crashes or hangs, lost telemetry or records, token exposure
priority
low
Fix when convenient
priority
medium
Worth fixing soon
status
needs-live-check
Fix pushed; needs a run on a live server before closing
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
goddard (Goddard) josh (Josh Wright)
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: josh/tws-zombies-scripts#1