Check results show raw values without units, so some are hard to read.
The game status check's observed value is the player count (native.ts:728), shown as "Observed 0".
The Plutonium checks show revisions as bare numbers, e.g. "4847" (native.ts:742-748).
ProvisioningProgress.svelte:68-70 prints expected and actual as-is for every check.
Screenshots
From the synthetic UI preview. Progress records and a launch recipe were added to the disposable fixture database using the labels the worker records. "After" images are mockups made in an uncommitted copy.
Before:
After (mockup):
Fix
Format check values per check type, e.g. "0 players" and "r4847"
Check results show raw values without units, so some are hard to read.
- The game status check's observed value is the player count (`native.ts:728`), shown as "Observed 0".
- The Plutonium checks show revisions as bare numbers, e.g. "4847" (`native.ts:742-748`).
- `ProvisioningProgress.svelte:68-70` prints `expected` and `actual` as-is for every check.
**Screenshots**
_From the synthetic UI preview. Progress records and a launch recipe were added to the disposable fixture database using the labels the worker records. "After" images are mockups made in an uncommitted copy._
Before:
After (mockup):
**Fix**
- Format check values per check type, e.g. "0 players" and "r4847"
Reviewed 6128a137cc. The fix is done, so I'm closing this.
Checklist
Values formatted per check.provisioningCheckValue (provisioning-presentation.ts:6-11) shows the game check as a player count using countLabel ("0 players", "1 player"), and both Plutonium checks as revisions ("r4847"). ProvisioningProgress.svelte:69-70 uses it for expected and observed values. Other values, such as maps and container states, are unchanged.
Review notes
Every numeric check the worker records is covered. occupancy is the only other check key, and nothing records it.
In the synthetic preview, the checks read "0 players" and "r4847".
The 4 related test files pass locally (210 tests), and npm run check reports 0 errors.
Minor and non-blocking: provisioningCheckValue has no unit test.
Reviewed 6128a137cc3ab1495f7239ccc7cab05773fb2313. The fix is done, so I'm closing this.
**Checklist**
- [x] **Values formatted per check.** `provisioningCheckValue` (`provisioning-presentation.ts:6-11`) shows the game check as a player count using `countLabel` ("0 players", "1 player"), and both Plutonium checks as revisions ("r4847"). `ProvisioningProgress.svelte:69-70` uses it for expected and observed values. Other values, such as maps and container states, are unchanged.
**Review notes**
- Every numeric check the worker records is covered. `occupancy` is the only other check key, and nothing records it.
- In the synthetic preview, the checks read "0 players" and "r4847".
- The 4 related test files pass locally (210 tests), and `npm run check` reports 0 errors.
- Minor and non-blocking: `provisioningCheckValue` has no unit test.
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Check results show raw values without units, so some are hard to read.
native.ts:728), shown as "Observed 0".native.ts:742-748).ProvisioningProgress.svelte:68-70printsexpectedandactualas-is for every check.Screenshots
From the synthetic UI preview. Progress records and a launch recipe were added to the disposable fixture database using the labels the worker records. "After" images are mockups made in an uncommitted copy.
Before:
After (mockup):
Fix
Reviewed
6128a137cc. The fix is done, so I'm closing this.Checklist
provisioningCheckValue(provisioning-presentation.ts:6-11) shows the game check as a player count usingcountLabel("0 players", "1 player"), and both Plutonium checks as revisions ("r4847").ProvisioningProgress.svelte:69-70uses it for expected and observed values. Other values, such as maps and container states, are unchanged.Review notes
occupancyis the only other check key, and nothing records it.npm run checkreports 0 errors.provisioningCheckValuehas no unit test.