Launch files card repeats its selection status four times and holds an unrelated launch action #87

Closed
opened 2026-10-08 19:11:23 -04:00 by goddard · 1 comment
Collaborator

The launch files card explains whether the files were queued, selected or only recorded four times, and it holds a create action that has nothing to do with this operation.

  • +page.svelte:50 sets the heading from the selection status.
  • +page.svelte:195 explains the same status in a paragraph.
  • LaunchRecipe.svelte:8 repeats it in the label above the map name.
  • LaunchRecipe.svelte:17 explains it again below the file list.
  • +page.svelte:198 puts "Launch another server" in this historical card, with its own paragraph explaining that it doesn't repair this instance.

Screenshots

From the synthetic UI preview. Progress records and a launch recipe were added to the disposable fixture database using the labels the worker records. "After" images are mockups made in an uncommitted copy.

Before:
Before

After (mockup):
After (mockup)

Fix

  • State the selection status once, in one line
  • Move "Launch another server" out of the card (for example into a header actions menu) or remove it from this page
The launch files card explains whether the files were queued, selected or only recorded four times, and it holds a create action that has nothing to do with this operation. - `+page.svelte:50` sets the heading from the selection status. - `+page.svelte:195` explains the same status in a paragraph. - `LaunchRecipe.svelte:8` repeats it in the label above the map name. - `LaunchRecipe.svelte:17` explains it again below the file list. - `+page.svelte:198` puts "Launch another server" in this historical card, with its own paragraph explaining that it doesn't repair this instance. **Screenshots** _From the synthetic UI preview. Progress records and a launch recipe were added to the disposable fixture database using the labels the worker records. "After" images are mockups made in an uncommitted copy._ Before: ![Before](https://gitea.thewrightserver.net/attachments/4925b5fe-3ca6-48e8-9299-f1dd959fdae2) After (mockup): ![After (mockup)](https://gitea.thewrightserver.net/attachments/6919d012-bc70-4f02-9dfc-59910242d487) **Fix** - [x] State the selection status once, in one line - [x] Move "Launch another server" out of the card (for example into a header actions menu) or remove it from this page
goddard added the
priority
low
type/ux
labels 2026-10-08 19:11:23 -04:00
josh was assigned by goddard 2026-10-08 19:11:23 -04:00
Author
Collaborator

Reviewed 15ab41d4a2. Both fix items are done, so I'm closing this.

Checklist

  • Selection status once. The card has a fixed "Launch files" heading and one status line, such as "Selected when creation began · 20 h ago" (+page.svelte:51,215). For historical records, LaunchRecipe no longer shows the status label above the map name or the explanation under the file list (LaunchRecipe.svelte:8,17).
  • "Launch another server" removed. The button, its explanation and the DeployServerDialog are gone from the job page. The provisioning guide now describes the card's three statuses instead.

Review notes

  • In the synthetic preview, a completed rebuild's card reads "Launch files · From Moon lobby · Selected when creation began · 20 h ago", followed by the map, config, image and the collapsible file list.
  • The 3 related test files pass locally (93 tests), and npm run check reports 0 errors.
  • Minor and non-blocking: nothing passes sourceDeploymentId to DeployServerDialog any more, so its source-loading branch (DeployServerDialog.svelte:79) is now unused and could go.
  • Minor and non-blocking: the status line uses a relative time, while the rest of this card's context (Technical details, Last evaluated) moved to absolute times in da623e8. Using the absolute time here would match.
Reviewed 15ab41d4a2a183496e89bf520158a1a490634a6d. Both fix items are done, so I'm closing this. **Checklist** - [x] **Selection status once.** The card has a fixed "Launch files" heading and one status line, such as "Selected when creation began · 20 h ago" (`+page.svelte:51,215`). For historical records, `LaunchRecipe` no longer shows the status label above the map name or the explanation under the file list (`LaunchRecipe.svelte:8,17`). - [x] **"Launch another server" removed.** The button, its explanation and the `DeployServerDialog` are gone from the job page. The provisioning guide now describes the card's three statuses instead. **Review notes** - In the synthetic preview, a completed rebuild's card reads "Launch files · From Moon lobby · Selected when creation began · 20 h ago", followed by the map, config, image and the collapsible file list. - The 3 related test files pass locally (93 tests), and `npm run check` reports 0 errors. - Minor and non-blocking: nothing passes `sourceDeploymentId` to `DeployServerDialog` any more, so its source-loading branch (`DeployServerDialog.svelte:79`) is now unused and could go. - Minor and non-blocking: the status line uses a relative time, while the rest of this card's context (Technical details, Last evaluated) moved to absolute times in da623e8. Using the absolute time here would match.
Sign in to join this conversation.