Successful provisioning operations show every passed check in full #83

Closed
opened 2026-10-08 19:11:21 -04:00 by goddard · 1 comment
Collaborator

A completed operation gets the same evidence layout as a failed one. A rebuild with five passed checks renders each as a full card with expected and observed values, source and two timestamps. The page is 2,223 px tall at 1440 px wide and 3,269 px on a 390 px phone.

  • ProvisioningProgress.svelte:62-70 renders every check as a card, whatever its result or the operation's state.
  • ProvisioningProgress.svelte:23 already opens only current, waiting or failed phases by default, but the checks list has no equivalent.

When everything passed, the only useful fact is that everything passed. This pairs with the single timeline in #82.

Screenshots

From the synthetic UI preview. Progress records and a launch recipe were added to the disposable fixture database using the labels the worker records. "After" images are mockups made in an uncommitted copy.

Before:
Before

After (mockup):
After (mockup)

Fix

  • When an operation is done, show "All N checks passed" in the outcome card
  • Keep passed check details collapsed, available on demand
A completed operation gets the same evidence layout as a failed one. A rebuild with five passed checks renders each as a full card with expected and observed values, source and two timestamps. The page is 2,223 px tall at 1440 px wide and 3,269 px on a 390 px phone. - `ProvisioningProgress.svelte:62-70` renders every check as a card, whatever its result or the operation's state. - `ProvisioningProgress.svelte:23` already opens only current, waiting or failed phases by default, but the checks list has no equivalent. When everything passed, the only useful fact is that everything passed. This pairs with the single timeline in #82. **Screenshots** _From the synthetic UI preview. Progress records and a launch recipe were added to the disposable fixture database using the labels the worker records. "After" images are mockups made in an uncommitted copy._ Before: ![Before](https://gitea.thewrightserver.net/attachments/3c0ed6bd-1d1e-415f-a1fa-82588402a787) After (mockup): ![After (mockup)](https://gitea.thewrightserver.net/attachments/d2d99880-ff92-4f9f-9784-71468a259b78) **Fix** - [x] When an operation is done, show "All N checks passed" in the outcome card - [x] Keep passed check details collapsed, available on demand
goddard added the
priority
medium
type/ux
labels 2026-10-08 19:11:21 -04:00
josh was assigned by goddard 2026-10-08 19:11:21 -04:00
Author
Collaborator

Reviewed 43c1a32065. Both fix items are done, so I'm closing this.

Checklist

  • "All N checks passed" in the outcome card. provisioningOutcome adds a checksSummary when every check on a done operation passed (provisioning-presentation.ts:128), shown under the description (+page.svelte:125).
  • Passed details collapsed. On a done operation, a phase starts closed unless it has a failed step or a check that didn't pass (ProvisioningProgress.svelte:23). The evidence is still inside, one click away.

Review notes

  • Good extra: the tests cover the other side too. fail, waiting and unknown evidence stays open even on a completed outcome, and phases stay open for every state other than done.
  • In the synthetic preview, a completed rebuild shows "✓ All 5 checks passed" and its three phases start collapsed.
  • The full test suite passes locally (205 files, 2,591 tests), and npm run check reports 0 errors.
Reviewed 43c1a32065db75feecfe4905ea600435eb85e5ce. Both fix items are done, so I'm closing this. **Checklist** - [x] **"All N checks passed" in the outcome card.** `provisioningOutcome` adds a `checksSummary` when every check on a done operation passed (`provisioning-presentation.ts:128`), shown under the description (`+page.svelte:125`). - [x] **Passed details collapsed.** On a done operation, a phase starts closed unless it has a failed step or a check that didn't pass (`ProvisioningProgress.svelte:23`). The evidence is still inside, one click away. **Review notes** - Good extra: the tests cover the other side too. `fail`, `waiting` and `unknown` evidence stays open even on a completed outcome, and phases stay open for every state other than done. - In the synthetic preview, a completed rebuild shows "✓ All 5 checks passed" and its three phases start collapsed. - The full test suite passes locally (205 files, 2,591 tests), and `npm run check` reports 0 errors.
Sign in to join this conversation.