Preparing and Empty sections still group single cards under game headings #131

Closed
opened 2026-10-09 19:55:59 -04:00 by goddard · 1 comment
Collaborator

The compact Servers sections still split cards by game, so a couple of empty lobbies take a heading and a short row each.

  • +page.svelte:257-259 marks Preparing and Empty lobbies as compact, but +page.svelte:534-541 still renders a game heading per group.
  • Each card already shows a BO1 or BO2 chip.
  • The game heading carries the "Add lobby" button (+page.svelte:537-540), so that button needs a new home if the headings go.

Screenshots

Before:
Before

After (mockup):
After (mockup)

Fix

  • In compact sections, drop the game headings, lay the cards out in one row, and move "Add lobby" to the section heading
The compact Servers sections still split cards by game, so a couple of empty lobbies take a heading and a short row each. - `+page.svelte:257-259` marks Preparing and Empty lobbies as compact, but `+page.svelte:534-541` still renders a game heading per group. - Each card already shows a BO1 or BO2 chip. - The game heading carries the "Add lobby" button (`+page.svelte:537-540`), so that button needs a new home if the headings go. **Screenshots** Before: ![Before](https://gitea.thewrightserver.net/attachments/9ef15847-5b2f-47d6-a914-70c829fb0f43) After (mockup): ![After (mockup)](https://gitea.thewrightserver.net/attachments/322b2c75-71bc-4289-9731-93d5757e6d58) **Fix** - In compact sections, drop the game headings, lay the cards out in one row, and move "Add lobby" to the section heading
goddard added the
priority
low
type/ux
labels 2026-10-09 19:55:59 -04:00
josh was assigned by goddard 2026-10-09 19:55:59 -04:00
Author
Collaborator

Reviewed 7442c6fd15. The fix is done, so I'm closing this.

Checklist

  • Flatten compact sections and move "Add lobby". Compact sections are now grouped with 'none' (+page.svelte:538), so they render one group with no heading, and the section heading carries "Add lobby" for operators (+page.svelte:532-536). In the preview, Preparing and Empty lobbies have no game headings, the two empty lobbies sit side by side in one row on desktop, and each section heading has "Add lobby". Live matches still groups by game.

Review notes

  • Run 859 passed on this commit. It doesn't add a test, so I checked it in the preview on desktop and on a phone.
  • Minor and non-blocking: the new buttons open the create dialog with no map selected, the same as "Create server" in the page header (+page.svelte:327), so the page now has three buttons for the same action. With map grouping, the old per-group button used to pre-select that map (+page.svelte:544). Compact sections no longer do.
Reviewed 7442c6fd15aa7495e884e8a83b61cd5a2bcab2ca. The fix is done, so I'm closing this. **Checklist** - [x] **Flatten compact sections and move "Add lobby".** Compact sections are now grouped with `'none'` (`+page.svelte:538`), so they render one group with no heading, and the section heading carries "Add lobby" for operators (`+page.svelte:532-536`). In the preview, Preparing and Empty lobbies have no game headings, the two empty lobbies sit side by side in one row on desktop, and each section heading has "Add lobby". Live matches still groups by game. **Review notes** - [Run 859](https://gitea.thewrightserver.net/josh/electric-cherry/actions/runs/859) passed on this commit. It doesn't add a test, so I checked it in the preview on desktop and on a phone. - Minor and non-blocking: the new buttons open the create dialog with no map selected, the same as "Create server" in the page header (`+page.svelte:327`), so the page now has three buttons for the same action. With map grouping, the old per-group button used to pre-select that map (`+page.svelte:544`). Compact sections no longer do.
Sign in to join this conversation.