drift update

tests/unit/drift-kinds.test.ts

@@ -1,5 +1,6 @@
 import { afterEach, beforeEach, describe, expect, it, vi } from 'vitest';
-import { mkdir, writeFile } from 'node:fs/promises';
+import { mkdir, readFile, rm, writeFile } from 'node:fs/promises';
+import { existsSync } from 'node:fs';
 import { join } from 'node:path';
 import { newFixture, type Fixture } from '../helpers/fixture.js';
 
@@ -42,10 +43,149 @@ describe('drift scanning', () => {
         );
 
         const drift = await scanServerDrift(server);
-        const byKind = Object.fromEntries(drift.map((d) => [d.kind, d.relPath]));
+        const untracked = drift.filter((d) => d.driftKind === 'untracked');
+        const byKind = Object.fromEntries(untracked.map((d) => [d.kind, d.relPath]));
         expect(byKind.script).toBe('stray.gsc');
         expect(byKind.config).toBe('stray.cfg');
         expect(byKind.plugin).toBe('stray.dll');
-        expect(drift.length).toBe(3);
+        expect(untracked.length).toBe(3);
+    });
+});
+
+// Deploys a promoted artifact to a scope-matching server, then deletes it
+// off disk so drift's "missing" pass has something to find.
+async function promoteAndOrphan(
+    createScript: (i: {
+        name: string;
+        kind: 'script' | 'plugin' | 'baseline' | 'config';
+        scopeType?: 'game' | 'map';
+        scopeValue?: string;
+        targetRelPath?: string;
+        content: Buffer;
+    }) => { script: { id: number }; version: { id: number } },
+    getLatestVersion: (id: number) => { id: number } | undefined,
+    openBeta: (i: {
+        scripts: Array<{ scriptId: number; scriptVersionId: number }>;
+        servers: string[];
+        waitForHealth: boolean;
+        waitForMatch: boolean;
+    }) => Promise<{ betaId: number }>,
+    promoteBeta: (id: number) => Promise<unknown>,
+    db: () => { prepare: (q: string) => { run: (...args: unknown[]) => unknown } }
+): Promise<{ scriptId: number }> {
+    const created = createScript({
+        name: 't5 hud',
+        kind: 'script',
+        scopeType: 'game',
+        scopeValue: 't5',
+        targetRelPath: 'hud.gsc',
+        content: Buffer.from('main(){}\n')
+    });
+    const ver = getLatestVersion(created.script.id)!;
+    const { betaId } = await openBeta({
+        scripts: [{ scriptId: created.script.id, scriptVersionId: ver.id }],
+        servers: ['t5_kino_1'],
+        waitForHealth: false,
+        waitForMatch: false
+    });
+    db().prepare(
+        `UPDATE beta_servers SET stage = 'ready', restarted_at = ? WHERE beta_id = ?`
+    ).run(new Date().toISOString(), betaId);
+    db().prepare(`UPDATE betas SET state = 'ready-promote' WHERE id = ?`).run(betaId);
+    await promoteBeta(betaId);
+    return { scriptId: created.script.id };
+}
+
+describe('missing artifact detection', () => {
+    it('flags a promoted script that is absent on a scope-matching server as missing, then restores it on reconcile', async () => {
+        const { seedServerRegistry } = await import('../../src/lib/server/fleet/servers.js');
+        const { createScript, getLatestVersion } = await import(
+            '../../src/lib/server/fleet/scripts.js'
+        );
+        const { openBeta, promoteBeta } = await import(
+            '../../src/lib/server/fleet/beta.js'
+        );
+        const { scanServerDrift, runDriftDeployment } = await import(
+            '../../src/lib/server/fleet/drift.js'
+        );
+        const { db } = await import('../../src/lib/server/db/index.js');
+        await seedServerRegistry();
+
+        await promoteAndOrphan(
+            createScript as never,
+            getLatestVersion as never,
+            openBeta as never,
+            promoteBeta as never,
+            db as never
+        );
+
+        const targetPath = join(
+            fixture.t5,
+            't5_kino_1',
+            'runtime/plutonium/storage/t5/raw/scripts/sp',
+            'hud.gsc'
+        );
+        // Sanity check: promoted script lands on disk.
+        expect(existsSync(targetPath)).toBe(true);
+
+        // Simulate someone deleting the file out-of-band.
+        await rm(targetPath, { force: true });
+
+        const drift = await scanServerDrift('t5_kino_1');
+        const missing = drift.filter((d) => d.driftKind === 'missing' && d.kind === 'script');
+        expect(missing.length).toBe(1);
+        expect(missing[0].relPath).toBe('hud.gsc');
+
+        const result = await runDriftDeployment({
+            servers: ['t5_kino_1'],
+            dryRun: false,
+            triggeredBy: 'ui'
+        });
+        expect(result.totalRestored).toBeGreaterThanOrEqual(1);
+        expect(existsSync(targetPath)).toBe(true);
+        const restored = await readFile(targetPath);
+        expect(restored.toString()).toBe('main(){}\n');
+    });
+
+    it('flags a scope-matching server whose composed dedicated_sp.cfg is missing', async () => {
+        const { seedServerRegistry } = await import('../../src/lib/server/fleet/servers.js');
+        const { createScript, getLatestVersion } = await import(
+            '../../src/lib/server/fleet/scripts.js'
+        );
+        const { openBeta, promoteBeta } = await import(
+            '../../src/lib/server/fleet/beta.js'
+        );
+        const { scanServerDrift } = await import('../../src/lib/server/fleet/drift.js');
+        const { db } = await import('../../src/lib/server/db/index.js');
+        await seedServerRegistry();
+
+        const baseline = createScript({
+            name: 't5 baseline',
+            kind: 'baseline',
+            scopeType: 'game',
+            scopeValue: 't5',
+            content: Buffer.from('set g_inactivity "190"\n')
+        });
+        const bVer = getLatestVersion(baseline.script.id)!;
+        const { betaId } = await openBeta({
+            scripts: [{ scriptId: baseline.script.id, scriptVersionId: bVer.id }],
+            servers: ['t5_kino_1'],
+            waitForHealth: false,
+            waitForMatch: false
+        });
+        db().prepare(
+            `UPDATE beta_servers SET stage = 'ready', restarted_at = ? WHERE beta_id = ?`
+        ).run(new Date().toISOString(), betaId);
+        db().prepare(`UPDATE betas SET state = 'ready-promote' WHERE id = ?`).run(betaId);
+        await promoteBeta(betaId);
+
+        const cfgPath = join(fixture.t5, 't5_kino_1', 'configs', 'dedicated_sp.cfg');
+        expect(existsSync(cfgPath)).toBe(true);
+        await rm(cfgPath, { force: true });
+
+        const drift = await scanServerDrift('t5_kino_1');
+        const missingCfg = drift.filter((d) => d.driftKind === 'missing' && d.kind === 'config');
+        expect(missingCfg.length).toBe(1);
+        expect(missingCfg[0].relPath).toBe('dedicated_sp.cfg');
     });
 });