Keep artifact list and beta queries free of file bytes

src/lib/server/fleet/scripts.ts

@@ -32,7 +32,6 @@ export interface ScriptVersionRow {
     release_version: string | null;
     sha256: string;
     size: number;
-    content: Buffer;
     notes: string | null;
     state: ScriptVersionState;
     kind: ArtifactKind;
@@ -137,14 +136,22 @@ export function listPromotedOverlaysForScope(
     return rows.filter((r) => !skip.has(r.id));
 }
 
+export const VERSION_COLUMNS = 'id, script_id, version, release_version, sha256, size, notes, state, kind, uploaded_at';
+
+export function getVersionContent(id: number): Buffer {
+    const row = db().prepare('SELECT content FROM script_versions WHERE id = ?').get(id) as { content: Buffer } | undefined;
+    if (!row) throw new ScriptError(`no such version (id=${id})`, 'no-such-version');
+    return row.content;
+}
+
 export function listVersions(scriptId: number): ScriptVersionRow[] {
     return db()
-        .prepare('SELECT * FROM script_versions WHERE script_id = ? ORDER BY version DESC')
+        .prepare(`SELECT ${VERSION_COLUMNS} FROM script_versions WHERE script_id = ? ORDER BY version DESC`)
         .all(scriptId) as ScriptVersionRow[];
 }
 
 export function getVersion(id: number): ScriptVersionRow | undefined {
-    return db().prepare('SELECT * FROM script_versions WHERE id = ?').get(id) as
+    return db().prepare(`SELECT ${VERSION_COLUMNS} FROM script_versions WHERE id = ?`).get(id) as
         | ScriptVersionRow
         | undefined;
 }
@@ -162,7 +169,7 @@ export function getVersionMetadata(id: number): ScriptVersionMetadata | undefine
 // upload, whether or not it has been promoted (current_version_id).
 export function getLatestVersion(scriptId: number): ScriptVersionRow | undefined {
     return db()
-        .prepare('SELECT * FROM script_versions WHERE script_id = ? ORDER BY version DESC LIMIT 1')
+        .prepare(`SELECT ${VERSION_COLUMNS} FROM script_versions WHERE script_id = ? ORDER BY version DESC LIMIT 1`)
         .get(scriptId) as ScriptVersionRow | undefined;
 }