Scope server snapshots and keep completed history off fleet refreshes

2026-10-05 15:37:56 -04:00
parent 030794635e
commit d24c52b5cc
12 changed files with 376 additions and 200 deletions
@@ -1,4 +1,6 @@
 import { afterEach, beforeEach, describe, expect, it, vi } from 'vitest';
+import { get } from 'svelte/store';
+import type { FleetOperation } from '../../src/lib/fleet-overview.js';

 vi.mock('$app/environment', () => ({ browser: true }));

@@ -33,6 +35,44 @@ async function setup() {
 }

 describe('fleet event refreshes', () => {
+    it('refreshes server history through one scoped request without replacing the fleet snapshot', async () => {
+        const store = await import('../../src/lib/ui/stores/fleet.js');
+        const integrations = { rcon: true, komodo: true, rconTimeoutMs: 2000, defaultRconHost: '' };
+        const snapshot = { servers: [], operations: [], integrations, serverNow: Date.now() };
+        store.hydrateFleet(snapshot);
+        const originalFleet = get(store.fleet);
+        const detail = store.createFleetStore('one / two');
+        detail.hydrateFleet(snapshot);
+        stop = detail.startFleetMonitor();
+        const history: FleetOperation[] = [{ key: 'deployment:done', group: 'deployment:done', kind: 'deployment',
+            server: 'one / two', state: 'done', label: 'Complete', detail: 'Complete', href: '/provisioning/done', startedAt: new Date().toISOString() }];
+        vi.mocked(fetch).mockResolvedValue(Response.json({ ...snapshot, operations: history }));
+        changed();
+        await vi.advanceTimersByTimeAsync(250);
+        expect(fetch).toHaveBeenCalledTimes(1);
+        expect(fetch).toHaveBeenCalledWith('/api/servers/one%20%2F%20two', expect.anything());
+        expect(get(detail.fleet).operations).toEqual(history);
+        expect(get(store.fleet)).toBe(originalFleet);
+        expect(get(store.fleet).operations).toEqual([]);
+    });
+
+    it('isolates late responses when navigating between server detail stores', async () => {
+        const { createFleetStore, fleet } = await import('../../src/lib/ui/stores/fleet.js');
+        const first = createFleetStore('first');
+        const second = createFleetStore('second');
+        let finish!: (response: Response) => void;
+        vi.mocked(fetch).mockImplementationOnce(() => new Promise(resolve => { finish = resolve; }));
+        const oldRequest = first.refreshFleet();
+        const newSnapshot = { serverNow: Date.now(), servers: [], integrations: {}, operations: [] };
+        vi.mocked(fetch).mockResolvedValue(Response.json(newSnapshot));
+        await second.refreshFleet();
+        const current = get(second.fleet);
+        finish(Response.json(newSnapshot)); await oldRequest;
+        expect(get(second.fleet)).toBe(current);
+        expect(get(fleet).receivedAt).toBe(0);
+        expect(fetch).toHaveBeenCalledTimes(2);
+    });
+
    it('coalesces bursts and refreshes at most once every two seconds with a trailing refresh', async () => {
        await setup();
        changed(); changed(); changed();