josh/electric-cherry
1
0
Fork 0
Code Issues 18 Pull Requests Actions Packages Projects Releases Wiki Activity

Fix fleet stale-status flicker during polling

Browse Source
This commit is contained in:
josh
2026-09-18 15:11:49 -04:00
parent f54cac8c50
commit 6d903adb31
6 changed files with 59 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/lib/server/fleet/health.ts
+6 -6
View File
@@ -1,24 +1,24 @@
import { freshStatusTimestamp } from '../../server-freshness.js';
export type Health = 'online' | 'stale' | 'offline' | 'starting';
const ONLINE_MAX_MS = 30_000;
const STALE_MAX_MS = 120_000;
/**
* Classify server health from its last successful RCON timestamp.
* `offline` if we've never seen it, or if RCON just failed, or if the last
* successful reply is >120s old. `stale` if the last reply is 30-120s old
* (RCON glitchy). `online` if fresh.
* `offline` if we've never seen it or the last successful reply is >120s old.
* `stale` on an RCON failure or if the last reply is 45-120s old.
* `online` if fresh, including the allowance for polling and delivery.
*/
export function classifyHealth(lastSeenAt: string | null, lastError: string | null, containerState?: string | null): Health {
if (containerState === 'starting' || containerState === 'restarting') return 'starting';
if (containerState && containerState !== 'running') return 'offline';
if (!lastSeenAt) return 'offline';
const age = Date.now() - new Date(lastSeenAt).getTime();
if (!Number.isFinite(age) || age < 0) return 'offline';
if (age <= ONLINE_MAX_MS) {
if (freshStatusTimestamp(lastSeenAt, Date.now())) {
// Even with a fresh last_seen, a very recent error demotes to stale
return lastError ? 'stale' : 'online';
}
if (!Number.isFinite(age) || age < 0) return 'offline';
if (age <= STALE_MAX_MS) return 'stale';
return 'offline';
}
src/lib/server/pipeline/worker.ts
+1 -1
View File
@@ -9,10 +9,10 @@ import { listServers, setServerField } from '../fleet/servers.js';
import { komodoInspectHealthy } from '../integrations/komodo.js';
import { restartSettling } from './restart-rollout.js';
import { classifyHealth } from '../fleet/health.js';
import { STATUS_REFRESH_MS } from '../../server-freshness.js';
import { scanMatchState } from '../fleet/match-log.js';
const TICK_MS = 15_000;
const STATUS_REFRESH_MS = 30_000;
// Cap concurrent UDP RCON calls so a 15-server fleet doesn't blast the
// host all at once.
const STATUS_CONCURRENCY = 4;