Protect RCON diagnostics and redact player addresses (Refs #61)

2026-10-08 16:47:34 -04:00
parent 29d2d9634c
commit 0cc4498b53
36 changed files with 280 additions and 83 deletions
@@ -49,12 +49,13 @@ export function serverObservation(server: ServerRow, evidence?: Evidence) {
    const state = (evidence ? evidence.settling : restartSettling(server.name)) ? 'restarting' : server.container_state;
    const ready = !provisioning && (!state || state === 'running' || state === 'unknown');
    const health = provisioning ? 'provisioning' : classifyHealth(server.last_seen_at, rconHealthError(rcon), state);
-    return selectServerObservation({ ...server, ...rcon, rcon_status: rcon, container_state: state, health,
+    // This projection is shared by viewer-visible snapshots. Never spread saved diagnostics.
+    const { last_reply_snippet: _snippet, ...publicServer } = server;
+    return selectServerObservation({ ...publicServer, ...rcon, rcon_status: rcon, container_state: state, health,
        status_source: null as 'telemetry' | 'rcon' | null,
        telemetry: (evidence ? evidence.telemetry : telemetryReport(server.name)) ?? undefined,
        telemetry_after: evidence ? evidence.submission : latestGameSubmission(server.name),
        last_error: ready ? server.last_error : null,
-        replySnippet: ready ? server.last_reply_snippet : null,
        active_since: ready ? server.active_since : null, inactive_since: ready ? server.inactive_since : null,
        game_started_at: ready ? server.game_started_at : null, game_ended_at: ready ? server.game_ended_at : null
    }, undefined, Date.now());