Coalesce fleet refreshes and suppress unchanged sweep events

2026-10-05 15:29:03 -04:00
parent 2af768011a
commit 030794635e
5 changed files with 198 additions and 5 deletions
@@ -16,6 +16,53 @@ afterEach(async () => {
 });

 describe('sweep', () => {
+    it('emits server state only when state, players, or error changes', async () => {
+        const { sweep } = await import('../../src/lib/server/pipeline/sweep.js');
+        const { seedServerRegistry } = await import('../../src/lib/server/fleet/servers.js');
+        const { db } = await import('../../src/lib/server/db/index.js');
+        const { subscribe } = await import('../../src/lib/server/pipeline/bus.js');
+        await seedServerRegistry();
+        db().prepare("INSERT INTO deployments (id, action, started_at, triggered_by) VALUES ('changes', 'test', ?, 'ui')")
+            .run(new Date().toISOString());
+        db().prepare(`INSERT INTO deployment_servers (deployment_id, server, files_changed, restart_state)
+            VALUES ('changes', 't5_zombie_theater_1', 1, 'pending')`).run();
+        const events = vi.fn();
+        const unsubscribe = subscribe(event => { if (event.type === 'server-state') events(event); });
+        try {
+            await sweep();
+            expect(events).toHaveBeenCalledTimes(1);
+            await sweep();
+            expect(events).toHaveBeenCalledTimes(1);
+
+            // Fresh check timestamps still update the campaign, without an SSE event.
+            const checkedAt = new Date().toISOString();
+            db().prepare('UPDATE server_deployments SET checked_at = ?').run(checkedAt);
+            await sweep();
+            expect(events).toHaveBeenCalledTimes(1);
+            expect(db().prepare("SELECT checked_at, attempts FROM deployment_servers WHERE deployment_id = 'changes'").get())
+                .toEqual({ checked_at: checkedAt, attempts: 1 });
+
+            db().prepare('UPDATE server_deployments SET players = 2').run();
+            await sweep();
+            expect(events).toHaveBeenCalledTimes(2);
+            expect(events).toHaveBeenLastCalledWith(expect.objectContaining({ state: 'pending', players: 2 }));
+            db().prepare("UPDATE server_deployments SET error = 'Waiting for players'").run();
+            await sweep();
+            expect(events).toHaveBeenCalledTimes(3);
+            expect(events).toHaveBeenLastCalledWith(expect.objectContaining({ error: 'Waiting for players' }));
+            db().prepare("UPDATE server_deployments SET state = 'failed'").run();
+            await sweep();
+            expect(events).toHaveBeenCalledTimes(4);
+            expect(events).toHaveBeenLastCalledWith(expect.objectContaining({ state: 'failed' }));
+            await sweep();
+            expect(events).toHaveBeenCalledTimes(4);
+            db().prepare("UPDATE server_deployments SET state = 'done'").run();
+            await sweep();
+            expect(events).toHaveBeenCalledTimes(5);
+            expect(events).toHaveBeenLastCalledWith(expect.objectContaining({ state: 'done', error: null }));
+        } finally { unsubscribe(); }
+    });
+
    it('queues pending rows in Provisioning even when integrations are unset', async () => {
        const { sweep } = await import('../../src/lib/server/pipeline/sweep.js');
        const { seedServerRegistry } = await import('../../src/lib/server/fleet/servers.js');