Remove unused SidebarField; add CI typecheck job before client Docker build
Some checks failed
Build & Push / Build Server (push) Has been cancelled
Build & Push / Build Client (push) Has been cancelled
Build & Push / TypeScript Check (client) (push) Has been cancelled

- Delete the now-unused SidebarField component from TicketDetail.tsx
- Add typecheck-client CI job that runs tsc --noEmit on the client before
  the Docker build, so TypeScript errors surface fast with a clear message
- build-client now depends on typecheck-client passing

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This commit is contained in:
Josh Wright
2026-03-31 12:14:48 -04:00
parent 618a9136f6
commit e6c2298ac2
2 changed files with 23 additions and 9 deletions

View File

@@ -10,6 +10,28 @@ env:
OWNER: ${{ github.repository_owner }} OWNER: ${{ github.repository_owner }}
jobs: jobs:
typecheck-client:
name: TypeScript Check (client)
runs-on: ubuntu-latest
steps:
- name: Checkout
uses: actions/checkout@v4
- name: Setup Node
uses: actions/setup-node@v4
with:
node-version: '22'
cache: 'npm'
cache-dependency-path: client/package-lock.json
- name: Install dependencies
run: npm ci
working-directory: ./client
- name: Type check
run: npx tsc --noEmit
working-directory: ./client
build-server: build-server:
name: Build Server name: Build Server
runs-on: ubuntu-latest runs-on: ubuntu-latest
@@ -38,6 +60,7 @@ jobs:
build-client: build-client:
name: Build Client name: Build Client
needs: typecheck-client
runs-on: ubuntu-latest runs-on: ubuntu-latest
steps: steps:
- name: Checkout - name: Checkout

View File

@@ -55,15 +55,6 @@ const AUDIT_COLORS: Record<string, string> = {
const COMMENT_ACTIONS = new Set(['COMMENT_ADDED', 'COMMENT_DELETED']) const COMMENT_ACTIONS = new Set(['COMMENT_ADDED', 'COMMENT_DELETED'])
function SidebarField({ label, children }: { label: string; children: React.ReactNode }) {
return (
<div>
<p className="text-xs font-medium text-gray-500 mb-1.5">{label}</p>
{children}
</div>
)
}
export default function TicketDetail() { export default function TicketDetail() {
const { id } = useParams<{ id: string }>() const { id } = useParams<{ id: string }>()
const navigate = useNavigate() const navigate = useNavigate()