From e6c2298ac23583dbea282bb03bc5cfdd1d5f7c6b Mon Sep 17 00:00:00 2001
From: Josh Wright <josh@Joshs-MacBook-Pro.local>
Date: Tue, 31 Mar 2026 12:14:48 -0400
Subject: [PATCH] Remove unused SidebarField; add CI typecheck job before
 client Docker build

- Delete the now-unused SidebarField component from TicketDetail.tsx
- Add typecheck-client CI job that runs tsc --noEmit on the client before
  the Docker build, so TypeScript errors surface fast with a clear message
- build-client now depends on typecheck-client passing

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
---
 .gitea/workflows/build.yml        | 23 +++++++++++++++++++++++
 client/src/pages/TicketDetail.tsx |  9 ---------
 2 files changed, 23 insertions(+), 9 deletions(-)

diff --git a/.gitea/workflows/build.yml b/.gitea/workflows/build.yml
index 85d21dd..16c28a9 100644
--- a/.gitea/workflows/build.yml
+++ b/.gitea/workflows/build.yml
@@ -10,6 +10,28 @@ env:
   OWNER: ${{ github.repository_owner }}
 
 jobs:
+  typecheck-client:
+    name: TypeScript Check (client)
+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v4
+
+      - name: Setup Node
+        uses: actions/setup-node@v4
+        with:
+          node-version: '22'
+          cache: 'npm'
+          cache-dependency-path: client/package-lock.json
+
+      - name: Install dependencies
+        run: npm ci
+        working-directory: ./client
+
+      - name: Type check
+        run: npx tsc --noEmit
+        working-directory: ./client
+
   build-server:
     name: Build Server
     runs-on: ubuntu-latest
@@ -38,6 +60,7 @@ jobs:
 
   build-client:
     name: Build Client
+    needs: typecheck-client
     runs-on: ubuntu-latest
     steps:
       - name: Checkout
diff --git a/client/src/pages/TicketDetail.tsx b/client/src/pages/TicketDetail.tsx
index 5036986..ac9860a 100644
--- a/client/src/pages/TicketDetail.tsx
+++ b/client/src/pages/TicketDetail.tsx
@@ -55,15 +55,6 @@ const AUDIT_COLORS: Record<string, string> = {
 const COMMENT_ACTIONS = new Set(['COMMENT_ADDED', 'COMMENT_DELETED'])
 
 
-function SidebarField({ label, children }: { label: string; children: React.ReactNode }) {
-  return (
-    <div>
-      <p className="text-xs font-medium text-gray-500 mb-1.5">{label}</p>
-      {children}
-    </div>
-  )
-}
-
 export default function TicketDetail() {
   const { id } = useParams<{ id: string }>()
   const navigate = useNavigate()