Unknown chat commands get no reply, and nothing tells players about .help #4

Open
opened 2026-10-12 10:09:28 -04:00 by goddard · 1 comment
Collaborator

Chat commands only respond to an exact match, and nothing tells a new player that .help exists. Players who guess wrong get no reply, and almost nobody finds .leaders.

  • tws_t5_common.gsc:109 (T6 tws_t6_common.gsc:110) answers only .help and .commands. Each module's listener does the same for its own command (tws_t5_afk.gsc:42-44, tws_t5_join.gsc:37, tws_t5_leaderboard.gsc:104, and the same on T6). Any other message starting with . or ! gets nothing back.
  • Chat from 7 to 12 October has .record (suspendedanima, Town #941, probably wanting .leaders), .info (D4rk_sH4d0wZ on Der Riese #876, Divine673 on Nacht #1103), .command (Divine673), .return (No0bxo on Der Riese #1089, before finding .back) and .unlock (TheGoldenGamer_1, Kino #1059). D4rk_sH4d0wZ tried .b, .w all, info and .info before .commands and .help.
  • The only connect message is the map record (lb_welcome, tws_t5_leaderboard.gsc:67-91, drawn by lb_show_hud at :140). It doesn't mention .help. Only JoshWright typed .leaders in that period, and Blade096 asked "whats the record 17?" in chat on Nacht #1038.

Fix

  • On T5 and T6, a message that starts with . or ! and whose first word isn't a registered command (level.tws_help_commands, tws_t5_common.gsc:95) or .commands gets "Unknown command. Type .help for the list", shown only to the sender.
  • .record works as .leaders, and .info and .command work as .help.
  • The welcome record shows a "Type .help for commands" line on T5 and T6.
  • The live checks (t6/scripts/NOTES.md:126 and the T5 README's module checks) cover an unknown command, a command with arguments (.w 2000) and each alias.
Chat commands only respond to an exact match, and nothing tells a new player that `.help` exists. Players who guess wrong get no reply, and almost nobody finds `.leaders`. - `tws_t5_common.gsc:109` (T6 `tws_t6_common.gsc:110`) answers only `.help` and `.commands`. Each module's listener does the same for its own command (`tws_t5_afk.gsc:42-44`, `tws_t5_join.gsc:37`, `tws_t5_leaderboard.gsc:104`, and the same on T6). Any other message starting with `.` or `!` gets nothing back. - Chat from 7 to 12 October has `.record` (suspendedanima, Town #941, probably wanting `.leaders`), `.info` (D4rk_sH4d0wZ on Der Riese #876, Divine673 on Nacht #1103), `.command` (Divine673), `.return` (No0bxo on Der Riese #1089, before finding `.back`) and `.unlock` (TheGoldenGamer_1, Kino #1059). D4rk_sH4d0wZ tried `.b`, `.w all`, `info` and `.info` before `.commands` and `.help`. - The only connect message is the map record (`lb_welcome`, `tws_t5_leaderboard.gsc:67-91`, drawn by `lb_show_hud` at `:140`). It doesn't mention `.help`. Only JoshWright typed `.leaders` in that period, and Blade096 asked "whats the record 17?" in chat on Nacht #1038. **Fix** - [ ] On T5 and T6, a message that starts with `.` or `!` and whose first word isn't a registered command (`level.tws_help_commands`, `tws_t5_common.gsc:95`) or `.commands` gets "Unknown command. Type .help for the list", shown only to the sender. - [ ] `.record` works as `.leaders`, and `.info` and `.command` work as `.help`. - [ ] The welcome record shows a "Type .help for commands" line on T5 and T6. - [ ] The live checks (`t6/scripts/NOTES.md:126` and the T5 README's module checks) cover an unknown command, a command with arguments (`.w 2000`) and each alias.
goddard added the
priority
medium
type/uxgame/t5game/t6
labels 2026-10-12 10:09:28 -04:00
josh was assigned by goddard 2026-10-12 10:09:28 -04:00
Author
Collaborator

Reviewed 3bb0b5178e. Unresolved; leaving open.

This review checks the current implementation against every acceptance criterion, regardless of commit references.

Checklist

  • Unknown-command reply. T5 common:99–112 and the equivalent T6 listener only recognize exact .help/.commands; no registered-first-word fallback handles unknown dot/bang commands.
  • Aliases. The help listener lacks .info/.command, and lb_chat_listener in both leaderboards only recognizes .leaders, not .record.
  • Welcome help hint. lb_show_hud renders the map record and Held by rows, without Type .help for commands.
  • Live-check documentation. The T5 module checks and T6 NOTES do not cover the requested unknown-command/argument/alias matrix.

Review notes

  • Read both common/leaderboard implementations and the corresponding validation docs. Existing leaderboard fixtures pass (137 checks), but do not implement or demonstrate the requested command-discovery behavior.

Next steps

  • Add sender-only unknown-command feedback, all three aliases and the welcome hint on both games; document and exercise argument-aware command recognition.
Reviewed 3bb0b5178e40ea6d322093283edb39f160542a07. Unresolved; leaving open. This review checks the current implementation against every acceptance criterion, regardless of commit references. **Checklist** - [ ] **Unknown-command reply.** T5 common:99–112 and the equivalent T6 listener only recognize exact .help/.commands; no registered-first-word fallback handles unknown dot/bang commands. - [ ] **Aliases.** The help listener lacks .info/.command, and lb_chat_listener in both leaderboards only recognizes .leaders, not .record. - [ ] **Welcome help hint.** lb_show_hud renders the map record and Held by rows, without Type .help for commands. - [ ] **Live-check documentation.** The T5 module checks and T6 NOTES do not cover the requested unknown-command/argument/alias matrix. **Review notes** - Read both common/leaderboard implementations and the corresponding validation docs. Existing leaderboard fixtures pass (137 checks), but do not implement or demonstrate the requested command-discovery behavior. **Next steps** - Add sender-only unknown-command feedback, all three aliases and the welcome hint on both games; document and exercise argument-aware command recognition.
Sign in to join this conversation.