From 21d9b54953c18c13bb6b391f7b0f6aabb099029f Mon Sep 17 00:00:00 2001
From: josh <josh@thewrightserver.net>
Date: Sun, 13 Sep 2026 18:44:34 -0400
Subject: [PATCH] Fix deploy modal closing when opening the map dropdown
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

The bounding-rect click-outside check treated native <select> option clicks
(which render below the dialog) as backdrop clicks. Switch to the standard
e.target === dialog check — only clicks on the dialog element itself close.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
---
 src/lib/ui/components/DeployServerDialog.svelte | 12 +++++-------
 1 file changed, 5 insertions(+), 7 deletions(-)

diff --git a/src/lib/ui/components/DeployServerDialog.svelte b/src/lib/ui/components/DeployServerDialog.svelte
index 77f6c9b..4195b6b 100644
--- a/src/lib/ui/components/DeployServerDialog.svelte
+++ b/src/lib/ui/components/DeployServerDialog.svelte
@@ -59,14 +59,12 @@
         open = false;
     }
 
-    // Click-outside-to-close (native <dialog> only supports Esc).
+    // Click-outside-to-close (native <dialog> only supports Esc). Only treat
+    // clicks whose target is the dialog element itself (the backdrop) as
+    // outside — a bounding-rect check catches native <select> dropdown
+    // options that render below the modal and closes the whole thing.
     function onDialogClick(e: MouseEvent): void {
-        if (!dialog) return;
-        const rect = dialog.getBoundingClientRect();
-        const inDialog =
-            e.clientX >= rect.left && e.clientX <= rect.right &&
-            e.clientY >= rect.top && e.clientY <= rect.bottom;
-        if (!inDialog) close();
+        if (e.target === dialog) close();
     }
 
     let selectedMap = $derived(maps.find((m) => m.slug === mapSlug));