feat(inventory): deep hardware capture + per-probe substeps + verbose logs
Extend Inventory stage from a one-liner summary to a per-probe substep emitter with ~20-30 narrative log lines per run. - spec: per-DIMM memory (slot/size/speed/manufacturer/part_number), richer CPU (vendor/stepping/physical_cores/flags), disk model/transport/rotational, NIC driver/pci_addr, GPU vram/pci/driver, new System/Baseboard/PSU/OS top-level sections. All fields omitempty so existing expected-spec YAML and artifacts stay compatible. - spec.Diff: new diffDIMMs/diffSystem/diffBaseboard/diffPSU/diffOS helpers; extended diffDisks/diffNICs/diffGPUs for new fields. GPU diff gains PCIAddr-pinned matching alongside count-by-model. - agent/probes/inventory: CPU (/proc/cpuinfo extended), Memory (dmidecode -t 17 multi-block), Disks (+model/transport/rotational), NICs (+driver/pci from sysfs), GPUs (VRAM from lspci -vv), new System/Baseboard (dmidecode -t system/baseboard), PSU (dmidecode -t 39), OS (/proc/sys/kernel/osrelease + /etc/os-release). All probes accept a Logger and emit per-finding info/warn lines. - agent/probes/firmware: parseDmidecodeAllSections for multi-block fixtures (memory / PSU). - agent/runner: Inventory case becomes 9 substep rows (CPU / Memory / Disks / NICs / GPUs / System / Baseboard / PSU / OS) with per-probe start/complete timestamps. - report: new Inventory HTML section between Stages and Firmware; resolveReporting loads the inventory.json artifact. - agent/tests/fakes/dmidecode: dispatches on -t flag to serve bios / memory / system / baseboard / 39 fixtures for unit tests. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This commit is contained in:
+39
-9
@@ -155,15 +155,35 @@ func runStage(ctx context.Context, stage string, claim *ClaimResponse, fwd *logF
|
||||
switch stage {
|
||||
case "Inventory":
|
||||
fwd.info("Inventory: probing host hardware")
|
||||
inv, err := probes.Collect()
|
||||
if err != nil {
|
||||
return stageOutcome{Outcome: tests.Outcome{Passed: false, Message: err.Error(), Summary: "probe error"}}
|
||||
log := probes.Logger{Info: fwd.info, Warn: fwd.warn}
|
||||
inv := &spec.Inventory{}
|
||||
var subs []tests.SubStepReport
|
||||
runSub := func(name string, fn func()) {
|
||||
start := time.Now()
|
||||
fn()
|
||||
subs = append(subs, tests.SubStepReport{
|
||||
Name: name,
|
||||
Passed: true,
|
||||
StartedAt: start,
|
||||
CompletedAt: time.Now(),
|
||||
})
|
||||
}
|
||||
fwd.info("Inventory: " + inventorySummary(inv))
|
||||
runSub("CPU", func() { inv.CPU = probes.CPU(log) })
|
||||
runSub("Memory", func() { inv.Memory = probes.Memory(log) })
|
||||
runSub("Disks", func() { inv.Disks = probes.Disks(log) })
|
||||
runSub("NICs", func() { inv.NICs = probes.NICs(log) })
|
||||
runSub("GPUs", func() { inv.GPUs = probes.GPUs(log) })
|
||||
runSub("System", func() { inv.System = probes.System(log) })
|
||||
runSub("Baseboard", func() { inv.Baseboard = probes.Baseboard(log) })
|
||||
runSub("PSU", func() { inv.PSU = probes.PSU(log) })
|
||||
runSub("OS", func() { inv.OS = probes.OS(log) })
|
||||
summary := inventorySummary(inv)
|
||||
fwd.info("Inventory: " + summary)
|
||||
return stageOutcome{
|
||||
Outcome: tests.Outcome{
|
||||
Passed: true,
|
||||
Summary: inventorySummary(inv),
|
||||
Passed: true,
|
||||
Summary: summary,
|
||||
SubSteps: subs,
|
||||
},
|
||||
Inventory: inv,
|
||||
}
|
||||
@@ -504,9 +524,19 @@ func requestHold(ctx context.Context, c *Client, fwd *logForwarder) error {
|
||||
}
|
||||
|
||||
func inventorySummary(inv *spec.Inventory) string {
|
||||
return fmt.Sprintf("cpu=%q cores=%d ram=%dGiB disks=%d nics=%d gpus=%d",
|
||||
inv.CPU.Model, inv.CPU.LogicalCores, inv.Memory.TotalGiB,
|
||||
len(inv.Disks), len(inv.NICs), len(inv.GPUs))
|
||||
populated := 0
|
||||
for _, d := range inv.Memory.Modules {
|
||||
if d.Populated {
|
||||
populated++
|
||||
}
|
||||
}
|
||||
slots := ""
|
||||
if len(inv.Memory.Modules) > 0 {
|
||||
slots = fmt.Sprintf(" (%d/%d slots)", populated, len(inv.Memory.Modules))
|
||||
}
|
||||
return fmt.Sprintf("cpu=%q cores=%d ram=%dGiB%s disks=%d nics=%d gpus=%d psu=%d",
|
||||
inv.CPU.Model, inv.CPU.LogicalCores, inv.Memory.TotalGiB, slots,
|
||||
len(inv.Disks), len(inv.NICs), len(inv.GPUs), len(inv.PSU))
|
||||
}
|
||||
|
||||
// firmwareSummary renders the one-liner surfaced in the stage tile:
|
||||
|
||||
Reference in New Issue
Block a user