chore: cleanup sprint — dead CSS, dedup helpers, handler refactor
CI / Lint + build + test (push) Successful in 1m34s
Release / detect (push) Successful in 4s
Release / build-live-image (push) Has been skipped
Release / bundle (push) Successful in 1m5s

Remove ~126 lines of orphaned CSS from tile slim-down and old detail
layout. Consolidate 4 duplicate duration formatters into shared
elapsed()/fmtElapsed() helpers. Break 160-line Result handler into
focused sub-functions. Implement real Hub.Shutdown() (was a no-op).
Standardize agent error responses to JSON. Replace panic() in router
init with error return. Extract magic numbers as named constants.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This commit is contained in:
2026-04-21 20:39:38 -04:00
parent c11573eeeb
commit 17ec55cb85
17 changed files with 242 additions and 438 deletions
+4 -3
View File
@@ -4,6 +4,7 @@
package httpserver
import (
"fmt"
"io/fs"
"net/http"
@@ -21,7 +22,7 @@ type Deps struct {
AgentAssetDir string // directory containing vetting-agent-linux-amd64; "" disables /assets
}
func NewRouter(d Deps) http.Handler {
func NewRouter(d Deps) (http.Handler, error) {
r := chi.NewRouter()
r.Use(middleware.RealIP)
r.Use(middleware.Recoverer)
@@ -29,7 +30,7 @@ func NewRouter(d Deps) http.Handler {
staticFS, err := fs.Sub(web.Static, "static")
if err != nil {
panic(err)
return nil, fmt.Errorf("extract static assets: %w", err)
}
r.Handle("/static/*", http.StripPrefix("/static/", http.FileServer(http.FS(staticFS))))
@@ -80,5 +81,5 @@ func NewRouter(d Deps) http.Handler {
r.Get("/register/quick.sh", d.UI.QuickRegisterScript)
r.Get("/events", d.UI.SSE)
return r
return r, nil
}
+8 -2
View File
@@ -72,7 +72,10 @@ func TestSSE_EndToEnd(t *testing.T) {
t.Fatalf("create host: %v", err)
}
router := NewRouter(Deps{UI: ui, Agent: agent})
router, err := NewRouter(Deps{UI: ui, Agent: agent})
if err != nil {
t.Fatalf("router: %v", err)
}
srv := httptest.NewServer(router)
t.Cleanup(srv.Close)
@@ -178,7 +181,10 @@ func TestSSE_SubStepEvent(t *testing.T) {
SpecDiffs: diffs, Runner: runner, EventHub: hub,
}
router := NewRouter(Deps{UI: ui, Agent: agent})
router, err := NewRouter(Deps{UI: ui, Agent: agent})
if err != nil {
t.Fatalf("router: %v", err)
}
srv := httptest.NewServer(router)
t.Cleanup(srv.Close)