From 86399c4ed0ae05fd9e628aa35083ce0782086a12 Mon Sep 17 00:00:00 2001 From: josh Date: Tue, 21 Apr 2026 20:34:33 -0400 Subject: [PATCH] Move status and audit label constants to shared/constants/labels STATUS_LABELS was defined in the server, AUDIT_LABELS and AUDIT_COLORS in the client. Both layers now import from a single shared source. Co-Authored-By: Claude Opus 4.6 --- client/src/pages/TicketDetail.tsx | 24 +--------------------- server/src/services/ticketService.ts | 7 +------ shared/constants/labels.ts | 30 ++++++++++++++++++++++++++++ 3 files changed, 32 insertions(+), 29 deletions(-) create mode 100644 shared/constants/labels.ts diff --git a/client/src/pages/TicketDetail.tsx b/client/src/pages/TicketDetail.tsx index c31de7e..f5f5e4a 100644 --- a/client/src/pages/TicketDetail.tsx +++ b/client/src/pages/TicketDetail.tsx @@ -63,29 +63,7 @@ const SEVERITY_OPTIONS = [ { value: 5, label: 'SEV 5 — Minimal' }, ]; -const AUDIT_LABELS: Record = { - CREATED: 'created this ticket', - STATUS_CHANGED: 'changed status', - ASSIGNEE_CHANGED: 'changed assignee', - SEVERITY_CHANGED: 'changed severity', - REROUTED: 'rerouted ticket', - TITLE_CHANGED: 'updated title', - OVERVIEW_CHANGED: 'updated overview', - COMMENT_ADDED: 'added a comment', - COMMENT_DELETED: 'deleted a comment', -}; - -const AUDIT_COLORS: Record = { - CREATED: 'bg-green-500', - STATUS_CHANGED: 'bg-blue-500', - ASSIGNEE_CHANGED: 'bg-purple-500', - SEVERITY_CHANGED: 'bg-orange-500', - REROUTED: 'bg-cyan-500', - TITLE_CHANGED: 'bg-gray-500', - OVERVIEW_CHANGED: 'bg-gray-500', - COMMENT_ADDED: 'bg-gray-500', - COMMENT_DELETED: 'bg-red-500', -}; +import { AUDIT_LABELS, AUDIT_COLORS } from '../../../shared/constants/labels'; const COMMENT_ACTIONS = new Set(['COMMENT_ADDED', 'COMMENT_DELETED']); diff --git a/server/src/services/ticketService.ts b/server/src/services/ticketService.ts index 729ab7b..a6e9699 100644 --- a/server/src/services/ticketService.ts +++ b/server/src/services/ticketService.ts @@ -40,12 +40,7 @@ const ticketListInclude = { _count: { select: { comments: true, attachments: true } }, } as const; -const STATUS_LABELS: Record = { - OPEN: 'Open', - IN_PROGRESS: 'In Progress', - RESOLVED: 'Resolved', - CLOSED: 'Closed', -}; +import { STATUS_LABELS } from '../../../shared/constants/labels'; export type TicketFilters = { status?: string; diff --git a/shared/constants/labels.ts b/shared/constants/labels.ts new file mode 100644 index 0000000..c7b97d6 --- /dev/null +++ b/shared/constants/labels.ts @@ -0,0 +1,30 @@ +export const STATUS_LABELS: Record = { + OPEN: 'Open', + IN_PROGRESS: 'In Progress', + RESOLVED: 'Resolved', + CLOSED: 'Closed', +}; + +export const AUDIT_LABELS: Record = { + CREATED: 'created this ticket', + STATUS_CHANGED: 'changed status', + ASSIGNEE_CHANGED: 'changed assignee', + SEVERITY_CHANGED: 'changed severity', + REROUTED: 'rerouted ticket', + TITLE_CHANGED: 'updated title', + OVERVIEW_CHANGED: 'updated overview', + COMMENT_ADDED: 'added a comment', + COMMENT_DELETED: 'deleted a comment', +}; + +export const AUDIT_COLORS: Record = { + CREATED: 'bg-green-500', + STATUS_CHANGED: 'bg-blue-500', + ASSIGNEE_CHANGED: 'bg-purple-500', + SEVERITY_CHANGED: 'bg-orange-500', + REROUTED: 'bg-cyan-500', + TITLE_CHANGED: 'bg-gray-500', + OVERVIEW_CHANGED: 'bg-gray-500', + COMMENT_ADDED: 'bg-gray-500', + COMMENT_DELETED: 'bg-red-500', +};