Phase 1d: react-hook-form + zod on Login and NewTicket

- Both forms use useForm with zodResolver against shared schemas
  (loginSchema, createTicketSchema)
- Field-level errors rendered inline under inputs
- isSubmitting drives button disabled state
- NewTicket: severity registered with valueAsNumber; CTISelect wrapped in
  nested Controllers (one per categoryId/typeId/itemId) since it controls
  three form fields as a single compound input
- Admin forms stay on useState for now — they get redesigned with shadcn
  dialogs in Phase 3, RHF migration lands with that

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This commit is contained in:
2026-04-18 15:35:29 -04:00
parent 17697ecf3b
commit 77679922a8
2 changed files with 100 additions and 88 deletions
+29 -27
View File
@@ -1,29 +1,37 @@
import { useState } from 'react';
import { useNavigate } from 'react-router-dom';
import { useForm } from 'react-hook-form';
import { zodResolver } from '@hookform/resolvers/zod';
import { loginSchema, type LoginInput } from '../../../shared/schemas/auth';
import { useAuth } from '../contexts/AuthContext';
export default function Login() {
const { login } = useAuth();
const navigate = useNavigate();
const [username, setUsername] = useState('');
const [password, setPassword] = useState('');
const [error, setError] = useState('');
const [loading, setLoading] = useState(false);
const handleSubmit = async (e: React.FormEvent) => {
e.preventDefault();
const {
register,
handleSubmit,
formState: { errors, isSubmitting },
} = useForm<LoginInput>({
resolver: zodResolver(loginSchema),
defaultValues: { username: '', password: '' },
});
const onSubmit = async (data: LoginInput) => {
setError('');
setLoading(true);
try {
await login(username, password);
await login(data.username, data.password);
navigate('/');
} catch {
setError('Invalid username or password');
} finally {
setLoading(false);
}
};
const inputClass =
'w-full bg-gray-800 border border-gray-700 text-gray-100 placeholder-gray-500 rounded-lg px-3 py-2 text-sm focus:outline-none focus:ring-2 focus:ring-blue-500 focus:border-transparent';
return (
<div className="min-h-screen bg-gray-950 flex items-center justify-center px-4">
<div className="w-full max-w-sm">
@@ -33,8 +41,9 @@ export default function Login() {
</div>
<form
onSubmit={handleSubmit}
onSubmit={handleSubmit(onSubmit)}
className="bg-gray-900 border border-gray-800 rounded-xl shadow-2xl p-8 space-y-4"
noValidate
>
{error && (
<div className="bg-red-500/10 border border-red-500/30 text-red-400 text-sm px-4 py-3 rounded-lg">
@@ -44,33 +53,26 @@ export default function Login() {
<div>
<label className="block text-sm font-medium text-gray-300 mb-1">Username</label>
<input
type="text"
value={username}
onChange={(e) => setUsername(e.target.value)}
required
autoFocus
className="w-full bg-gray-800 border border-gray-700 text-gray-100 placeholder-gray-500 rounded-lg px-3 py-2 text-sm focus:outline-none focus:ring-2 focus:ring-blue-500 focus:border-transparent"
/>
<input type="text" autoFocus className={inputClass} {...register('username')} />
{errors.username && (
<p className="mt-1 text-xs text-red-400">{errors.username.message}</p>
)}
</div>
<div>
<label className="block text-sm font-medium text-gray-300 mb-1">Password</label>
<input
type="password"
value={password}
onChange={(e) => setPassword(e.target.value)}
required
className="w-full bg-gray-800 border border-gray-700 text-gray-100 placeholder-gray-500 rounded-lg px-3 py-2 text-sm focus:outline-none focus:ring-2 focus:ring-blue-500 focus:border-transparent"
/>
<input type="password" className={inputClass} {...register('password')} />
{errors.password && (
<p className="mt-1 text-xs text-red-400">{errors.password.message}</p>
)}
</div>
<button
type="submit"
disabled={loading}
disabled={isSubmitting}
className="w-full bg-blue-600 text-white py-2 rounded-lg text-sm font-medium hover:bg-blue-700 disabled:opacity-50 transition-colors"
>
{loading ? 'Signing in...' : 'Sign in'}
{isSubmitting ? 'Signing in...' : 'Sign in'}
</button>
</form>
</div>