Catalyst

josh/Catalyst

Fork 0

...

Author	SHA1	Message	Date
josh	515ff8ddb3	Merge branch 'dev' into fix/db-permissions-and-error-handling CI / test (pull_request) Successful in 9m28s Details CI / build-dev (pull_request) Has been skipped Details	2026-03-28 11:48:36 -04:00
josh	4ce7df4649	Merge pull request 'fix: skip db boot init in test env to prevent parallel worker lock' (#4 ) from fix/db-boot-test-isolation into dev CI / test (push) Successful in 9m29s Details CI / build-dev (push) Has been cancelled Details Reviewed-on: #4	2026-03-28 11:41:55 -04:00
joshandClaude Sonnet 4.6	6c04a30c3a	fix: skip db boot init in test env to prevent parallel worker lock CI / test (pull_request) Successful in 9m29s Details CI / build-dev (pull_request) Has been skipped Details Vitest runs test files in parallel workers. Each worker imports server/db.js, which triggered module-level init(DEFAULT_PATH) unconditionally. Two workers racing to open the same SQLite file caused "database is locked", followed by process.exit(1) killing the worker — surfacing as: Error: process.exit unexpectedly called with "1" Fix: guard the boot init block behind NODE_ENV !== 'test'. Vitest sets NODE_ENV=test automatically. Each worker's beforeEach(() => _resetForTest()) initialises its own :memory: database, so no file coordination is needed. process.exit(1) is also guarded by the same condition — it must never fire inside a test runner process. TDD: two regression tests added to tests/db.test.js documenting the expected boot behaviour and proving the module loads cleanly in parallel. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>	2026-03-28 11:31:55 -04:00

Author

SHA1

Message

Date

josh

515ff8ddb3

Merge branch 'dev' into fix/db-permissions-and-error-handling

CI / test (pull_request) Successful in 9m28s

Details

CI / build-dev (pull_request) Has been skipped

Details

2026-03-28 11:48:36 -04:00

josh

4ce7df4649

Merge pull request 'fix: skip db boot init in test env to prevent parallel worker lock' (#4 ) from fix/db-boot-test-isolation into dev

CI / test (push) Successful in 9m29s

Details

CI / build-dev (push) Has been cancelled

Details

Reviewed-on: #4

2026-03-28 11:41:55 -04:00

joshandClaude Sonnet 4.6

6c04a30c3a

fix: skip db boot init in test env to prevent parallel worker lock

CI / test (pull_request) Successful in 9m29s

Details

CI / build-dev (pull_request) Has been skipped

Details

Vitest runs test files in parallel workers. Each worker imports server/db.js,
which triggered module-level init(DEFAULT_PATH) unconditionally. Two workers
racing to open the same SQLite file caused "database is locked", followed
by process.exit(1) killing the worker — surfacing as:

  Error: process.exit unexpectedly called with "1"

Fix: guard the boot init block behind NODE_ENV !== 'test'. Vitest sets
NODE_ENV=test automatically. Each worker's beforeEach(() => _resetForTest())
initialises its own :memory: database, so no file coordination is needed.

process.exit(1) is also guarded by the same condition — it must never
fire inside a test runner process.

TDD: two regression tests added to tests/db.test.js documenting the
expected boot behaviour and proving the module loads cleanly in parallel.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

2026-03-28 11:31:55 -04:00

Compare commits

Diff Content Not Available