Goddard goddard
  • Joined on 2025-12-11
goddard closed issue josh/electric-cherry#74 2026-10-09 17:19:37 -04:00
Telemetry endpoint lacks body size and field length limits
goddard commented on issue josh/electric-cherry#74 2026-10-09 17:19:36 -04:00
Telemetry endpoint lacks body size and field length limits

Reviewed f0afd6de67c576471db33d8e0b5fc94aaab15cf6. I also checked the telemetry part of 9eb3aa84c3f2e6b2a7d18880c3bc53cd218f8852, which references #94. The telemetry body is capped and player…

goddard closed issue josh/electric-cherry#76 2026-10-09 17:18:41 -04:00
Process-wide prepared statement cache can leak statement modes between callers
goddard commented on issue josh/electric-cherry#76 2026-10-09 17:18:41 -04:00
Process-wide prepared statement cache can leak statement modes between callers

Reviewed bd16737dd87c9339814b67cedfa4bded75b05058. The process-wide statement cache is gone, so each caller now gets its own statement and modes can't leak. I'm closing this.

Checklist

  • …
goddard closed issue josh/electric-cherry#72 2026-10-09 17:17:40 -04:00
Restrict expensive viewer endpoints (/api/drift, GitHub release lookup)
goddard commented on issue josh/electric-cherry#72 2026-10-09 17:17:39 -04:00
Restrict expensive viewer endpoints (/api/drift, GitHub release lookup)

Reviewed 15fb90200a02c8339cd4c5e3c45a06a9a3fae0c4. Viewers can no longer trigger drift scans or GitHub release lookups, so I'm closing this.

Checklist

  • **Restrict /api/drift to…
goddard closed issue josh/electric-cherry#101 2026-10-09 17:17:05 -04:00
Two tests compare 1 MiB buffers with toEqual and can time out in CI
goddard commented on issue josh/electric-cherry#101 2026-10-09 17:17:04 -04:00
Two tests compare 1 MiB buffers with toEqual and can time out in CI

Reviewed 4c1f2cdb8f4d53a42b86a275e6285c94f20e740c. Both 1 MiB comparisons now use Buffer.equals, and the two tests are well clear of the timeout, so I'm closing this.

Checklist

  • …
goddard opened issue josh/electric-cherry#101 2026-10-09 16:56:20 -04:00
Two tests compare 1 MiB buffers with toEqual and can time out in CI
goddard closed issue josh/electric-cherry#91 2026-10-09 16:41:21 -04:00
Remove the unused launch-from-recipe path in DeployServerDialog
goddard commented on issue josh/electric-cherry#91 2026-10-09 16:41:20 -04:00
Remove the unused launch-from-recipe path in DeployServerDialog

Reviewed 8fcb8312a3eb7f17489112383a2e488998f16503. The unused launch-from-recipe path is gone, and the Servers page dialog behaves exactly as before, so I'm closing this.

Checklist

  • …
goddard closed issue josh/electric-cherry#95 2026-10-09 16:41:08 -04:00
Login refuses a third concurrent password check and tells the user to wait 15 minutes
goddard commented on issue josh/electric-cherry#95 2026-10-09 16:41:07 -04:00
Login refuses a third concurrent password check and tells the user to wait 15 minutes

Reviewed 4059fc30d659134208e0d5233b8bf29975df2402. Password checks now wait in a short queue instead of failing, and "busy" responses ask for a 2-second retry instead of 15 minutes, so I'm closing…

goddard closed issue josh/electric-cherry#100 2026-10-09 16:17:58 -04:00
Add a CI workflow that runs the checks and tests on every push
goddard commented on issue josh/electric-cherry#100 2026-10-09 16:17:57 -04:00
Add a CI workflow that runs the checks and tests on every push

Reviewed 5cf284f413b42f1c7ca7d94cd34b6a887aaba835. The workflow runs every check, the build and lint, and its first run on this commit passed, so I'm closing this.

Checklist

  • **Workflow…
goddard closed issue josh/electric-cherry#77 2026-10-09 16:02:46 -04:00
Add formatting and linting (Prettier and ESLint)
goddard closed issue josh/electric-cherry#99 2026-10-09 16:02:46 -04:00
Viewers can read global fleet settings, which the docs say are admin-only
goddard commented on issue josh/electric-cherry#77 2026-10-09 16:02:45 -04:00
Add formatting and linting (Prettier and ESLint)

Reviewed 16469e2d43bcde12dd3a29c432a617f3c38c7049. Prettier and ESLint are in place, the whole repo passes npm run lint, and the reformat didn't change behaviour, so I'm closing this.

**Checklis…

goddard commented on issue josh/electric-cherry#99 2026-10-09 16:02:44 -04:00
Viewers can read global fleet settings, which the docs say are admin-only

Reviewed 8ed059b8d360f2bf599d524f9249d42a1fedb2c2. GET /api/settings is now admin-only and the docs table matches, so I'm closing this.

Checklist

  • **Make GET /api/settings admin-only.…
goddard opened issue josh/electric-cherry#100 2026-10-09 15:37:29 -04:00
Add a CI workflow that runs the checks and tests on every push