Goddard goddard
  • Joined on 2025-12-11
goddard commented on issue josh/electric-cherry#136 2026-10-10 20:16:48 -04:00
Matches stay "In progress" with a growing time after their server stops reporting

Reviewed 03e2d08a38578b08ece21829c298b0d9c0ce7df9. Both fix items are done, so I'm closing this.

Checklist

  • Interrupt the open match on stop. Once the agent confirms the container…
goddard closed issue josh/electric-cherry#142 2026-10-10 18:54:57 -04:00
Metrics has no player trend, so it can't show unique or new players over the selected range
goddard commented on issue josh/electric-cherry#142 2026-10-10 18:54:56 -04:00
Metrics has no player trend, so it can't show unique or new players over the selected range

Reviewed e3e740cea3e1149f9bb73630a52e1865d05275b5. All ten fix items are done, so I'm closing this.

Checklist

  • Per-period counts. readPlayerMetrics (metrics-players.ts:5-87)…
goddard closed issue josh/electric-cherry#102 2026-10-10 18:41:03 -04:00
The 256 MiB migration-memory test runs beside other tests and can push them past their timeout
goddard closed issue josh/electric-cherry#141 2026-10-10 18:41:02 -04:00
Metrics says history is kept for 31 days regardless of the retention setting
goddard closed issue josh/electric-cherry#140 2026-10-10 18:41:02 -04:00
Autoscaling guide sends operators to Metrics for measurements it doesn't show
goddard commented on issue josh/electric-cherry#102 2026-10-10 18:40:53 -04:00
The 256 MiB migration-memory test runs beside other tests and can push them past their timeout

Reviewed 7fcf1cded20647459b50cac820bf83e4377ddf45. Both fix items are done, so I'm closing this.

Checklist

  • Own Vitest project with a later groupOrder. vite.config.ts now defines…
goddard commented on issue josh/electric-cherry#141 2026-10-10 18:40:53 -04:00
Metrics says history is kept for 31 days regardless of the retention setting

Reviewed d6041e40ef0168306c454d828af57db43ef18349. The fix item is done, so I'm closing this.

Checklist

  • Show the configured metricsKeepDays. readMetrics now returns `metricsKeepD…
goddard commented on issue josh/electric-cherry#140 2026-10-10 18:40:53 -04:00
Autoscaling guide sends operators to Metrics for measurements it doesn't show

Reviewed 528ed7f37aafdd7bd13b5bb6653dadfb8f971d2d. All three fix items are done, so I'm closing this.

Checklist

  • Autoscaling section on Metrics. metrics-autoscaling.ts:6-89 reads…
goddard opened issue josh/electric-cherry#142 2026-10-10 18:35:40 -04:00
Metrics has no player trend, so it can't show unique or new players over the selected range
goddard commented on issue josh/electric-cherry#102 2026-10-10 18:04:36 -04:00
The 256 MiB migration-memory test runs beside other tests and can push them past their timeout

Another failure from the same cause: run 855 on 0bfda267ecd3b18d35aafb670b8a4cdb871ba41d, a metrics-only commit. One test…

goddard commented on issue josh/electric-cherry#139 2026-10-10 16:59:22 -04:00
Instances tab lists every reused autoscaling lobby name as its own history

Reviewed 0bfda267ecd3b18d35aafb670b8a4cdb871ba41d. It resolves the non-blocking note from my last review, and all three fix items are still done, so this stays closed.

Checklist

  • …
goddard closed issue josh/electric-cherry#139 2026-10-10 16:51:15 -04:00
Instances tab lists every reused autoscaling lobby name as its own history
goddard commented on issue josh/electric-cherry#139 2026-10-10 16:51:14 -04:00
Instances tab lists every reused autoscaling lobby name as its own history

Reviewed aebfc7a78359da4547a5a85d42350ca0311cde79. All three fix items are done, so I'm closing this.

Checklist

  • Instances tab removed. The tabs are now Maps and Autoscaling signals…
goddard closed issue josh/electric-cherry#138 2026-10-10 16:31:38 -04:00
Metrics ignores match records, so it can't show matches started or group sizes per map
goddard commented on issue josh/electric-cherry#138 2026-10-10 16:31:37 -04:00
Metrics ignores match records, so it can't show matches started or group sizes per map

Reviewed 616b1937edaab482cfadc973f6f484d5d0b60e3a. All four fix items are done, so I'm closing this.

Checklist

  • Matches-started card. MetricsSummary.svelte:68 adds "Matches…
goddard commented on issue josh/electric-cherry#137 2026-10-10 16:14:20 -04:00
Metrics is built for a fixed lineup, so its headline, capacity card and hosting advice misread an autoscaled fleet

Reviewed ea932ec563ef4b95c4ea4e703bf0a6c2bc4f317a. It fixes both non-blocking notes from my last review, and all nine fix items are still done, so this stays closed.

Checklist

  • **No…
goddard closed issue josh/electric-cherry#137 2026-10-10 16:07:26 -04:00
Metrics is built for a fixed lineup, so its headline, capacity card and hosting advice misread an autoscaled fleet
goddard commented on issue josh/electric-cherry#137 2026-10-10 16:07:25 -04:00
Metrics is built for a fixed lineup, so its headline, capacity card and hosting advice misread an autoscaled fleet

Reviewed 33da4482a6c6b6dbb20246bc6663e419c272a0c8. All nine fix items are done, so I'm closing this.

Checklist

  • No empty lobby replaces all lobbies full. For each collection,…
goddard opened issue josh/electric-cherry#141 2026-10-10 14:33:50 -04:00
Metrics says history is kept for 31 days regardless of the retention setting